regression on getDescendants().filter() method

[Pete Smith]

Used to work in 1.3.2:

	getAllValidatableDescendants: function(){
		return this.getDescendants().filter(function(widg){
			return widg.isValid;
		});
	}

Had to change to in 1.4

	getAllValidatableDescendants: function(){
		var desc = this.getDescendants();
		return dojo.filter(desc, function(widg){
			return widg.isValid;
		});
	}

Otherwise got object does not support this method (filter)

[bill]

Your description is missing a lot of information; it has no test case and doesn't list which component you are referring. I'm guessing you are referring to dijit but no idea what widget you are talking about.

Anyway, _Widget.getDescendants().filter() was never supposed to work in any version of dijit. The API contract for getDescendants() is that it returns an array of widgets. That was documented in 1.3 and 1.4.

[Pete Smith]

Bill I am referring to the this.getDescendants().filter which used to work. I had to do var desc = this.getDescendants(); dojo.filter(desc, function(widg)) on the results of this.getDescendants.

[bill]

But what is "this"?

[Pete Smith]

bill - sorry for not being clear enough. It is just any widget that extends _Widget.

[bill]

OK, thanks. Hmm, that's strange, _Widget.getDescendants() hasn't changed significantly from the 1.3 days, it seems like your 1.3.2 code wouldn't work either in the case when this.containerNode wasn't defined.