Opened 14 years ago

Closed 14 years ago

Last modified 8 years ago

#1027 closed defect (fixed)

[patch][cla] Dialog modality problem when first opened

Reported by: morris Owned by: Douglas Hays
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: Cc: [email protected]…
Blocked By: Blocking:

Description

When you first open the dialog using tests/widget/test_Dialog.html the focus stays on the link 'Show' and pressing Tab moves you on to the other inputs on the page (behind the dialog).

You can also sometimes click on the addressbar and tab into the page while a dialog is opened (I think this is related to not having the focus on the dialog, or to issue #1026 i.e. if this issue and #1026 are fixed then I suspect we might fix that problem too).

Attachments (2)

Dialog.js_BUG_TRAC_1027.patch​ (439 bytes) - added by neil 14 years ago.
Patch to permit focus on modal dialog when dialog first rendered. For $DOJO_ROOT/src/widget/Dialog.js
1027.patch​ (3.6 KB) - added by Douglas Hays 14 years ago.
must allow tab for a11y but prevent other keyboard input

Download all attachments as: .zip

Change History (12)

comment:1 Changed 14 years ago by dylan

Owner: changed from anonymous to Neil Roberts

comment:2 Changed 14 years ago by neil

Owner: changed from Neil Roberts to neil

Changed 14 years ago by neil

Attachment: Dialog.js_BUG_TRAC_1027.patch​ added

Patch to permit focus on modal dialog when dialog first rendered. For $DOJO_ROOT/src/widget/Dialog.js

comment:3 Changed 14 years ago by dylan

Milestone: 0.4 → 0.4.1
Summary: Dialog modality problem when first opened → [patch][need cla] Dialog modality problem when first opened

comment:4 Changed 14 years ago by bill

Owner: changed from neil to Douglas Hays
Summary: [patch][need cla] Dialog modality problem when first opened → [patch][cla] Dialog modality problem when first opened

Neil (Joshi) has already filed a CLA; updating title. Doug, if this patch looks OK to you (and works OK) please check it in.

comment:5 Changed 14 years ago by Douglas Hays

Cc: [email protected]… added

This patch does not work on Opera 9/WinXP.

Changed 14 years ago by Douglas Hays

Attachment: 1027.patch​ added

must allow tab for a11y but prevent other keyboard input

comment:6 Changed 14 years ago by Douglas Hays

Status: new → assigned

Please verify with the 1027.patch file and test on various browsers. Each exhibits slightly different behavior wrt keyboard tabbing. Some form of tabbing has to be enabled for a11y.

comment:7 Changed 14 years ago by Douglas Hays

Resolution: → fixed
Status: assigned → closed

(In [6576]) Fixes #1027

comment:8 Changed 14 years ago by Douglas Hays

Resolution: → fixed

(In [6577]) Fixes #1027 (trunk)

comment:9 Changed 13 years ago by (none)

Milestone: 0.4.1

Milestone 0.4.1 deleted

comment:10 Changed 8 years ago by bill

In [30070]:

Use keydown rather than synthetic dojo/_base/connect._keypress event for Dialog, TooltipDialog, InlineEditBox, and dijit/popup.

These modules need to be changed together so that when the user hits the ESCAPE key while an InlineEditBox is in edit mode, the Dialog or TooltipDialog doesn't close too. That will happen if the InlineEditBox calls event.stop() on a keydown event but the Dialog is listening to keypress, or vice-versa.

For some reason InlineEditBox was listening to both keypress and keydown; changed it to just listener keydown by removing the onkeypress data-dojo-attach-event from the template.

Also removed some strange code in Dialog from [6577] (refs #1027) that doesn't seem to be needed anymore.

Fixes #16385 !strict.

Note: See TracTickets for help on using tickets.