[patch][cla] Dialog modality problem when first opened

[morris]

When you first open the dialog using tests/widget/test_Dialog.html the focus stays on the link 'Show' and pressing Tab moves you on to the other inputs on the page (behind the dialog).

You can also sometimes click on the addressbar and tab into the page while a dialog is opened (I think this is related to not having the focus on the dialog, or to issue #1026 i.e. if this issue and #1026 are fixed then I suspect we might fix that problem too).

[neil]

Patch to permit focus on modal dialog when dialog first rendered. For $DOJO_ROOT/src/widget/Dialog.js

[bill]

Neil (Joshi) has already filed a CLA; updating title. Doug, if this patch looks OK to you (and works OK) please check it in.

[Douglas Hays]

This patch does not work on Opera 9/WinXP.

[Douglas Hays]

must allow tab for a11y but prevent other keyboard input

[Douglas Hays]

Please verify with the 1027.patch file and test on various browsers. Each exhibits slightly different behavior wrt keyboard tabbing. Some form of tabbing has to be enabled for a11y.

[Douglas Hays]

(In [6576]) Fixes #1027

[Douglas Hays]

(In [6577]) Fixes #1027 (trunk)

[(none)]

Milestone 0.4.1 deleted

[bill]

In [30070]:

Use keydown rather than synthetic dojo/_base/connect._keypress event for Dialog, TooltipDialog, InlineEditBox, and dijit/popup.

These modules need to be changed together so that when the user hits the ESCAPE key while an InlineEditBox is in edit mode, the Dialog or TooltipDialog doesn't close too. That will happen if the InlineEditBox calls event.stop() on a keydown event but the Dialog is listening to keypress, or vice-versa.

For some reason InlineEditBox was listening to both keypress and keydown; changed it to just listener keydown by removing the onkeypress data-dojo-attach-event from the template.

Also removed some strange code in Dialog from [6577] (refs #1027) that doesn't seem to be needed anymore.

Fixes #16385 !strict.