Changes between Initial Version and Version 2 of Ticket #10269


Ignore:
Timestamp:
Nov 5, 2009, 5:40:00 PM (10 years ago)
Author:
Eugene Lazutkin
Comment:

The line in question was added on purpose because some browsers were "loosing" node properties and node children when adding to the DOM tree. We need to retest all supported browsers to see if this is still the case.

This ticket does not fixes a bug that affects functionality or performance in any significant way, so technically it is not a "defect". Most probably we can qualify it as an "enhancement".

Additionally you should raise this issue with svgweb --- bugs should be fixed where they are introduced, not in all potential clients.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #10269

    • Property Status changed from new to assigned
    • Property Type changed from defect to enhancement
    • Property Milestone changed from 1.4 to future
  • Ticket #10269 – Description

    initial v2  
    11With the following patch we could get one less code line on the svg.js rendering backend. The appendChild() itself is done in the this.add() method called just a couple of lines below (in the code branch for the shapes which don't have any parent).
    22
    3 
    4 Index: svg.js
    5 ===================================================================
     3{{{
    64--- svg.js      (revision 20722)
    75+++ svg.js      (working copy)
    86@@ -647,7 +647,6 @@
    9                                 node = _createElementNS(svg.xmlns.svg, shapeType.nodeType);
     7                        node = _createElementNS(svg.xmlns.svg, shapeType.nodeType);
    108 
    11                         shape.setRawNode(node);
     9                        cshape.setRawNode(node);
    1210-                       this.rawNode.appendChild(node);
    1311                        shape.setShape(rawShape);
    1412                        this.add(shape);
    1513                        return shape;   // dojox.gfx.Shape
     14}}}