Opened 10 years ago

Closed 10 years ago

#10254 closed enhancement (fixed)

dojox.image.LightboxDialog - No programmatic way to remove group

Reported by: gimecoffee Owned by: dante
Priority: high Milestone: 1.5
Component: Dojox Version: 1.3.2
Keywords: Lightbox groups Cc:
Blocked By: Blocking:

Description

LightboxDialog? addImage will add images to a group but there doesn't appear to be a method for removing them or removing a whole group. I have 3 different FilteringSelect? on a page that show lightbox images only for the selected item in each. I can't just destroy the whole LightboxDialog? when a select changes because the other 2 selects may not be changing and their groups would then be gone requiring me to add them again. My workaround is to test for the existence of the group and if it exists set it to null. Then add the images for the new selection:


if(lb._groups.styleimage) { windowlb?._groups.styleimage=null }


It would be nice if their were a destroy, removeGroup or removeGroupImage method in a future version. Presumably that would require some kind of ID on each image when added to the dialog.

Change History (3)

comment:1 Changed 10 years ago by Adam Peller

Owner: changed from Adam Peller to dante

comment:2 Changed 10 years ago by dante

Milestone: tbd1.5
Status: newassigned

comment:3 Changed 10 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [21598]) fixes #10808 - allowing the template to be overridden by adjusting how the 'tmp' image is replaced back into the lightbox. previously it was appended to a containerNode, but now will be placed relative to the existing img node prior to its destruction.

fixes #10254 - adding in Lightbox.destroy to unregister an image from the master Dialog and adding a programatic way for items to be removed from a master Dialog by inference. (matching .href and .group members)

fixes #10538 - the css changes from _CssStateMixin caused the .dojoxLightbox classes to be overridden. making them more specific (avoiding !important) seems to reapply the padding and maintains overflow:hidden

Note: See TracTickets for help on using tickets.