Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#10248 closed defect (fixed)

DataGrid does not display data from XmlStore using Dojo 1.4.0b1

Reported by: tbeauvais Owned by: Nathan Toone
Priority: blocker Milestone: 1.4
Component: DojoX Data Version: 1.4.0b
Keywords: Grid XmlStore Cc:
Blocked By: Blocking:

Description

If you add the dojox.grid.DataGrid? to a page that uses the dojox.data.XmlStore? as its data store the grid renders, but there is no data displayed in the cells. This is easily reproducible using the dojo-release-1.4.0b1-src\dojox\grid\tests\test_data_grid_multiStores.html test where you can see the empty grid cells for the XmlStore?.

I suspect it's an issue with the XmlStore?, but I'm not sure. Using Firebug I do see the XML data being requested.

I tried this with IE 6 and FF 3.5.3.

Attachments (1)

test_fix.patch (540 bytes) - added by Jared Jurkiewicz 10 years ago.
Fix for the test to use formatters to get string representation back.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by Jared Jurkiewicz

XmlStore? has not changed in 1.4, so I cannot imagine it's an issue with the store itself.

comment:2 Changed 10 years ago by Jared Jurkiewicz

Owner: changed from Jared Jurkiewicz to Nathan Toone

The behavior change is in DataGrid?, not the store. Verified. The store tests, for those attributes, return a JS object representing the value of the attribute (which itself was another item) with a toString() function. The Grid used to call the toString function to get a string representation of the value. Now it apparently doesn't.

I'll attach a patch for the test to use formatters to just call toString()), but i'm not sure that's the right fix. So, assigning to Toonetown to review/comment on/fix in DataGrid?.

this is definitely a regression in behavior. DataGrid? used to have no issues with that return time (and properly called toString())

Changed 10 years ago by Jared Jurkiewicz

Attachment: test_fix.patch added

Fix for the test to use formatters to get string representation back.

comment:3 Changed 10 years ago by Nathan Toone

Resolution: fixed
Status: newclosed

(In [20757]) Fixes #10248 - only return stub widget formatting for "real" widgets...ones that have a startup function. !strict

comment:4 Changed 10 years ago by Nathan Toone

Milestone: tbd1.4
Note: See TracTickets for help on using tickets.