[patch] [cla] [regression] GridContainer resize problem with StackContainer child

[Mathevet julien]

I have a GridContainer? with 2 column. And each column take screen size... The resize method of LayoutContainer? doesn't detect gridContainer has parent.

[Mathevet julien]

And in this example tabContainer isn't shown also.

[Mathevet julien]

Seem adding isLayoutContainer: true, to GridContainer? fix problem.

In fact Child widgets are loaded before, grid initialize column.

[Mathevet julien]

This patch fix build order and child startup. It also fix: #10244

[Mathevet julien]

This patch doesn't fix this example, but it fixs many of mines. I use a widget that extends StackContainer. And works for all of yours. I have juste reorganized build order. And this is repect more "widget layout".

[Mathevet julien]

Main problem in your svn version is the GridContainer? doesn't respect the new design of inheritance of StackContainer?. I fix it and fix startup childs. I have also reduced size code, removing unused or duplicated variable. I hope you will add this patch for 1.4 version. Currently your version doesn't work for me.

[bill]

Do you have a CLA? I looked up your user info but it just says that your name is Moogle Moogle.

[Mathevet julien]

I have send it today .... But I couldn't modify my user first on trac or on dojotoolkit website... My name is Julien Mathevet

[dante]

Hmmm, so I'm not seeing anything useful in the tabContainer test case attached. The patch applies fine, and looks ok but to be honest I'm not clear on what this is fixing.

[Mathevet julien]

Yes I know it's not a good example but there few widget that extends LayouWidget?. The main problem is startup order. In current GridContainer it tries to start many time childs without any reasons... And then my child start before the grid. Then there column aren't set up an child take wrong size. And there is also conceptual problem.

And it fixes also getChildren method: #10244. So the resize method doesn't work.

Ok I will try to add a more clear example.

Current code:

startup:function(){
    // Start childs and get wrong size
    this.inherited(arguments);
    // create columns
    this._createCells();
		
    // start again childs
     dojo.forEach(this.getChildren(), function(child){
	if(!child.started && !child._started){
           child.startup();
	}
     });
     // move child in table grid
     if(this.usepref !== true){
			this[(this.isAutoOrganized ? "_organizeServices" : "_organizeServicesManually")]();
		}else{ 
			//console.info("GridContainer organised by UserPref");
			return;
		}
                // create grids
		this.init();
	},

[Mathevet julien]

If you look at _Container, startup says:

// summary:
			//		Called after all the widgets have been instantiated and their
			//		dom nodes have been inserted somewhere under dojo.doc.body.
			//
			//		Widgets should override this method to do any initialization
			//		dependent on other widgets existing, and then call
			//		this superclass method to finish things off.
			//
			//		startup() in subclasses shouldn't do anything
			//		size related because the size of the widget hasn't been set yet.

So this.inherited(arguments); need to be call at end of child startup. why dev has done that. Because getChildren method return only node are directly under ContainerNode. So after move childs inside table grid, getChildren method return an empty array. So childs aren't started. But in current code child are started before GridContainer finish to be built. In svn tests they are only ContentPane child. But !_LayoutWidget child doesn't manage resize method like ContentPane and they take size of ContainerNode and not of grid cell.

There is also confusing method between addService and addChild. If you do addChild after startup it will not be insertted inside grid. And if you do addService before startup child will be never startup.

So this patch fix getChildren, startup, addChild in repecting parents conception.

[dante]

(In [20733]) fixes #10241, #10244, #7469, #9271 - addCHild/startup regression fix from moogle w/slight style modifictions. other bugs/issues need new tickets and patches, and prefereably additional test cases \!strict