[patch][ccla] Format can't be removed/reset via dropdown

[rsccag]

After a format has been applied to selected text via the dropdown menu, it is not possible to remove the format again. Only another format can be applied. This is not consistent since entered text has no initial format. There should be an entry named 'none' or 'remove format'.

[rsccag]

Apply format to created text

[rsccag]

Format can only be changed the is no going back

[Jared Jurkiewicz]

There is a remove format command supported by the editor: ​http://docs.dojocampus.org/dijit/Editor#builtin-commands

'removeFormat'

Enable it and see if it works the way you expect. Reopen if it does not.

[Jared Jurkiewicz]

Hm, does not look like it does. It will remove bold/italic, etc, but not the actual format. removeFormat needs to be augmented.

[Jared Jurkiewicz]

I've prototype-implemented this. The fix is more complex than I would like, but there is no native 'unformatblock' type command. So I have to manually do it via selection traversal and manipulation. Whee. Still needs unit tests, but the basics work.

[Jared Jurkiewicz]

Patch to fix the issue. Adds new function to selection code. This can be reused (I do similar in the NormalizeIndentOutdent?? code), so with that add, I can code-reduce that dojox plugin as well.

[Jared Jurkiewicz]

(In [21047]) Updating FontChoice? to have a 'none' setting along with helper inSelection function many plugins need. refs #10237

[Jared Jurkiewicz]

(In [21048]) Use selection.js inSelection. code reduction. fixes #10237

[bill]

Great, thanks for adding this. Please add automated tests for this new feature though.

[Jared Jurkiewicz]

Working on a test for this. Should be done in a day (or less if my local network behaves!)

[Jared Jurkiewicz]

(In [21111]) Adding in tests for FontChoice? remove format. fixes #10237

[Jared Jurkiewicz]

(In [21296]) Fixing an issue on IE with format removal, ID identifies DIV as P in queryCommandValue, which causes state issues, so have to manually check it to ensure it really is a P or not. refs #10237

[davidmark]

Replying to jaredj:

(In [21296]) Fixing an issue on IE with format removal, ID identifies DIV as P in queryCommandValue, which causes state issues, so have to manually check it to ensure it really is a P or not. refs #10237

Re-opening. Adding a browser sniff is just buying more trouble. That's why there is a seemingly endless stream of adjustments for this stuff.

[davidmark]

Replying to jaredj:

(In [21296]) Fixing an issue on IE with format removal, ID identifies DIV as P in queryCommandValue, which causes state issues, so have to manually check it to ensure it really is a P or not. refs #10237

[Adam Peller]

feel free to suggest an alternative, otherwise I suspect this will be closed

[Jared Jurkiewicz]

Exactly. If you have a solution that doesn't require a sniff, I'm all for it. Otherwise I'm just going to close this.

[Jared Jurkiewicz]

(In [21336]) Just always check if the value is P, since IE returns incorrectly for div. Avoids browser check to just always check. fixes #10237

[bill]

Jared, is there any reason you didn't clear the block formatting via a simple?

editor.execCommand(command, "DIV");

With the current solution, it collapses multiple blocks into a single block, i.e.

<h1>heading</h1>
<h2>sub - heading</h2>

becomes just

heading sub - heading

I would have expected this:

<div>heading</div>
<div>sub - heading</div>

That is also (visually) what Microsoft Word does when you select the "Clear formatting" choice.

I do realize this is complicated by the fact that EnterKeyHandling? can run in three modes (BR, DIV, P), or not be loaded at all. Still, using

editor.execCommand(command, "DIV");

seems like an improvement over the current behavior, and it gets rid of 100 lines of code.

Note: Another test is to run test_FontChoice.html, and clear all the formatting. Neither solution clears the lists.