[cla] Searching the Ancestor Hierarchy for the first DOMNode.nodeName

[ole]

/**
 * Returns the first ancestor node found that has the 
 * parentNodeName argument as the DOMNode.nodeName.
 */
findAncestorNodeByName: function(/*String*/ ancestorNodeName, /*DOMNode*/ domNode)
{
  var ancestorNode = domNode.parentNode;
  if (ancestorNode && ancestorNode.nodeName.toLowerCase() ==
        ancestorNodeName.toLowerCase() ) {
    return ancestorNode;        
  }
  return ancestorNode && this.findAncestorNodeByName(ancestorNodeName, ancestorNode);
}

[Eugene Lazutkin]

Probably simpler (and more efficient) to do it using a loop rather than a straight recursion. As is the code doesn't work. And it uses this, which we try to avoid.

[Eugene Lazutkin]

Fixing obvious bugs in the code keeping it recursive and with this.

[ole]

The original code works for me, but I code all utility functions on classes and use them only on other classes as mixins. I was thinking that that using the this keyword would be OK here, since there's no delegation to other objects until the function completes...But I'm not crazy about it either :).

[ole]

Per discussion with Peter, Ben, and Les this does the job:

	/**
	 * Returns the first ancestor node found that has the 
	 * parentNodeName argument as the DOMNode.nodeName.
	 */
	findAncestorNodeByName: function(/*String*/ ancestorNodeName, /*String*/ domNodeID)
	{
		return dojo.query("#" + domNodeID).parents(ancestorNodeName)[0];
	}

Note that dojo.query("#" + domNodeID).closest(ancestorNodeName)[0] will also work, but I'm assuming "parents" is better, because the intention is to search ancestors and I think closest also looks at siblings, etc.

Also there's a similar function in dijit (dijit.range.getAncestor(..) ). It would be great if these were grouped under something like dojox.html.search...

[James Burke]

To clarify, closest() only looks at parent elements, not siblings. The difference between closest and parents is that closest considers the current node in the query. In this case, parents() is correct to use.

So given that there is a function already that supports this function via dojo.NodeList?-traverse's parents() call, I am going to close this ticket.