Opened 13 years ago

Closed 12 years ago

#1021 closed defect (wontfix)

ComboBox + dojo.validate = need unified interface for form based widgets

Reported by: jkuhnert@… Owned by: dante
Priority: high Milestone:
Component: Dojox Version: 0.3
Keywords: Cc: jkuhnert@…
Blocked By: Blocking:

Description

The current ComboBox? implementation stores selected values in hidden form fields. This is probably ok, but the current implementation of dojo.validate.check() doesn't look at type="hidden" input fields - which is probably the right thing to do.

I think either the ComboBox? should be refactored to live within forms a little more happily, or dojo.validate.check() needs to be refactored to take into account widgets wrapping form fields? If they all implemented a standard getValue() function that it could check that may help. (I think Select does provide this )

The only other issue involved would be decorating invalid fields wrapped by widgets. In the case of ComboBox? this is non trivial as the only path to the node is via looking up the widget and then looking at textInputNode. (textInputNode has no name/id attribute )

I'd submit a patch but this one seems to require more direction/input than that would allow.

Change History (8)

comment:1 Changed 13 years ago by bill

[4509] sets style to display:none rather than using type="hidden", thus dojo.validate.check() will check the node.

As for decorating incorrect values, not sure what to do there. Perhaps some kind of combination between ComboBox? and the Validation widgets. (But there are many validation widgets)

comment:2 Changed 13 years ago by dylan

Owner: changed from anonymous to jkuhnert

comment:3 Changed 13 years ago by jkuhnert

Milestone: 0.40.5
Status: newassigned
Summary: ComboBox + dojo.validateComboBox + dojo.validate = need unified interface for form based widgets

comment:4 Changed 13 years ago by bill

Hi Jesse. Let's talk about this one before making any changes. We definitely need a base class for all the form widgets (see http://manual.dojotoolkit.org/WikiHome/DojoDotBook/Book44) and I suppose that class should have a markInvalid() function or something like that, but I don't really want to think about it until after 0.4. Also, the FormContainer? class is related as it has similar functionality.

comment:5 Changed 13 years ago by jkuhnert

Yes, I do think we need something, though I'm less thrilled with the idea of a base "class". We should all save this discussion for 0.5 though as I think there should be a lot of changes in general made to how we think about and write widgets.

comment:6 Changed 12 years ago by bill

Component: WidgetsDojox
Milestone: 0.9

Not sure what to do w/this bug. I filed #3190 which satisfies this requirement in my mind, but you may not be happy w/it since it will probably require that every form field be a widget. In any case, dojo.validate is gone in 0.9, so this has to be a dojox thing if anything. Changing category.

comment:7 Changed 12 years ago by Adam Peller

Owner: changed from jkuhnert to dante
Status: assignednew

comment:8 Changed 12 years ago by dante

Resolution: wontfix
Status: newclosed

most 0.9 widgets have validation builtin. the direction of dojox.validate is unknown, interested parties should take this to dojox dev discussion forum on dojotoolkit.org .

Note: See TracTickets for help on using tickets.