#10206 closed defect (fixed)
fix memory leaks
Reported by: | bill | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | Dijit | Version: | 1.4.0b |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Ticket for fixing memory leaks in themeTester.html or other places, found from http://blogs.msdn.com/gpde/pages/javascript-memory-leak-detector-v2.aspx
Change History (16)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
comment:5 Changed 11 years ago by
comment:7 Changed 11 years ago by
comment:8 Changed 11 years ago by
comment:9 Changed 11 years ago by
(In [20662]) Code to deregister iframes/main window to avoid memory leaks on IE. Also, about mousedown listener, switched to using attachEvent()/attachListener() rather than dojo.connect() because the latter leaves a dojo._ieDispatcher() handler on dojo.doc (even after the dojo.disconnect() call), which causes a leak warning.
This change solves the leak, although could probably come up with a better design for the handle returned from registerWin()/registerIframe(). But that's an implementation detail. I was also conflicted about whether unregisterIframe() should take a handle or a reference to the iframe; ended up passing in a handle, like dojo.disconnect().
comment:10 Changed 11 years ago by
comment:11 Changed 11 years ago by
comment:12 Changed 11 years ago by
(In [20683]) dojo.connect() to <html> rather than document to avoid [reports of] memory leaks on IE6. [8245] put in code to attach to document rather than <body>, and although attaching to <body> doesn't work for right-click, I didn't see any problems attaching to <html>. Tested on IE6, IE8, FF3.5 and Safari for both Shift-F10 and right-click. Refs #10206 !strict.
comment:13 Changed 11 years ago by
comment:14 Changed 11 years ago by
comment:15 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
That clears up all the memory leaks while loading (then immediately closing) themeTester, there are probably some more but they can be filed as separate tickets.
(In [20647]) Just fixing some comments I noticed while working on memory leaks, refs #10206 !strict.