Opened 11 years ago
Closed 11 years ago
#10195 closed enhancement (fixed)
[patch] [cla] Additional form elements for FileInputAuto & FileInputBlind
Reported by: | Ian Fouls | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.5 |
Component: | Dojox | Version: | 1.4.0b |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Please see the attached file for modification to FileInputAuto? & FileInputBlind?. This provides a callback to append additional DOM elements to the form before submission via the iframe.
This is done out of frustration with the FileIploader? not working in a dialog, please see ticket #9996. I need to get some code out the door that works!!!
Attachments (2)
Change History (9)
Changed 11 years ago by
Attachment: | FileInputAuto.js added |
---|
comment:1 Changed 11 years ago by
Component: | General → Dojox |
---|---|
Owner: | changed from anonymous to dante |
Changed 11 years ago by
Attachment: | FileInputAuto.js.patch added |
---|
comment:3 Changed 11 years ago by
Summary: | Additional form elements for FileInputAuto & FileInputBlind → [patch] [cla] Additional form elements for FileInputAuto & FileInputBlind |
---|
comment:4 Changed 11 years ago by
would it make more sense to have a generic mixin for content:{} object, so that you may simply specify a pre-send callback like:
new FileInputBlah({ onBeforeSend: function(){ return {}; } });
then, internally FileInputBlah? would just:
dojo.io.iframe.send({ form: this._form, content: this.onBeforeSend() });
it seems actually using the formnode (which is technically private) to clone inputs etc would be harder/more expensive than just being able to specify a function which will return the intended data to mix into content: param
comment:5 Changed 11 years ago by
Milestone: | tbd → 1.5 |
---|---|
Status: | new → assigned |
comment:6 Changed 11 years ago by
Agreed, your solution is far more elegant, I needed to get some code out to a customer and I've already overrrun deadlines by some considerable amount. With neither FileImput? or FileUploader? working (at least a day lost here!!!) I needed a quick method of resolving the problem.
comment:7 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
We cannot accept patches without a CLA. Patch format is preferred.