Opened 10 years ago

Closed 7 years ago

#10180 closed defect (patchwelcome)

Grid row selector icon does not show in a dialog

Reported by: Ian Fouls Owned by:
Priority: high Milestone: future
Component: DojoX Grid Version: 1.4.0b
Keywords: grid rowselector dialog icon Cc:
Blocked By: Blocking:

Description

When using rowSelector="nnpx" in a grid, the icons are shows correctly outside of a dialog but when contained the row icon is only partially visible.

Secondly having to redifine Dojo styles (dojoxGridMasterHeader & dojoxGridRowbarSelected) to display the icon is not good practice. This makes showing more than one grid with different icons impossible. Could we please have 2 additional attributes for the RowSelector? class, maybe headerIconClass & rowIconClass that can be pulled in and appended to the template class.

Please see the attached test file, the same grid is shown inside and outside of a dislog with the issue clearly visible inside the dialog.

Attachments (2)

test_dojo.html (3.8 KB) - added by Ian Fouls 10 years ago.
navtoolbar16.png (8.5 KB) - added by Ian Fouls 10 years ago.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by Ian Fouls

Attachment: test_dojo.html added

comment:1 Changed 10 years ago by Nathan Toone

Milestone: tbd1.5

Would you mind posting the image file (/cms/images/navtoolbar16.png) you reference in css as well (so that I can test it out...since the bug is relating to icons)?

Changed 10 years ago by Ian Fouls

Attachment: navtoolbar16.png added

comment:2 Changed 10 years ago by Ian Fouls

I have attached the toolbar image file as requested however this isn't really neccessary as the image is applied as a background in CSS. You can see the effects of the problem even without the background image as the data rows are shifted left by several pixels compared to the header when contained in a dialog.

comment:3 Changed 9 years ago by Nathan Toone

Milestone: 1.5future
Owner: Nathan Toone deleted

Moving my tickets to future, as I am not currently working on them.

comment:4 Changed 7 years ago by bill

DojoX Grid and EnhancedGrid are deprecated in favor of dgrid and gridx.

You should upgrade your code to use one of those two grids.

We will consider patches to the old DojoX Grid code though.

comment:5 Changed 7 years ago by bill

Resolution: patchwelcome
Status: newclosed
Note: See TracTickets for help on using tickets.