Opened 10 years ago

Closed 6 years ago

#10171 closed feature (fixed)

[patch][cla]collapsible fieldset widget

Reported by: Jens Arps Owned by: bill
Priority: high Milestone: 1.9
Component: Dijit - Form Version: 1.3.2
Keywords: Cc: nonken
Blocked By: Blocking:

Description (last modified by Eugene Lazutkin)

A proposal for a collapsible fieldset widget.

It inherits from TitlePane, so it is accessible and brings all ContentPane goodness. The code is dead-simple, but it's missing and I think many people would like to use such a widget.

A test page is over here: http://jensarps.de/tests/dojo_tests/test_Fieldset.html.

Attachments (2)

fieldset.patch (4.6 KB) - added by Jens Arps 10 years ago.
patch including the Fieldset.js file and it's template
fieldset2.patch (9.7 KB) - added by bill 6 years ago.
patch against latest code

Download all attachments as: .zip

Change History (14)

Changed 10 years ago by Jens Arps

Attachment: fieldset.patch added

patch including the Fieldset.js file and it's template

comment:1 Changed 10 years ago by Jens Arps

Uh, it seems like I should have put [patch][cla] in the title, but I can't change it anymore. Sorry about that.

comment:2 Changed 10 years ago by liucougar

Summary: collapsible fieldset widget[patch][cla]collapsible fieldset widget

comment:3 Changed 10 years ago by liucougar

the patch does not have any css changes, is that required by the widget to function properly?

comment:4 Changed 10 years ago by Jens Arps

Thanks for changing the title.

No, there's no CSS required for the widget to work. To change the plus/minus chars into images, a theme had to copy the .dijitArrowNode rules from the TitlePane? to Fieldset.

comment:5 Changed 10 years ago by Eugene Lazutkin

Description: modified (diff)
Owner: set to bill

comment:6 Changed 10 years ago by bill

Milestone: tbd1.5

Thanks, this does seem like something lots of people would want (I feel like I've seen it before in many place but can't remember where.)

I hadn't realized that fieldsets have a <legend> tag with a rich text title. Seems like we might want to hijack that for normal TitlePane too so that it can have also have a rich text title.

comment:7 Changed 9 years ago by bill

Milestone: 1.51.6

comment:8 Changed 8 years ago by dante

Cc: nonken added
Milestone: 1.61.7
Owner: changed from bill to dante

you can't get too crazy with the richtext in a LEGEND node, sadly. Its like a P, spans and em and whatnot. I'll take this, or perhaps since Jensarps is an uxebu'er one of those folks can proxy commit this for him.

comment:9 Changed 8 years ago by bill

Milestone: 1.71.8

running out of time for 1.7

comment:10 Changed 7 years ago by bill

Component: DijitDijit - Form
Milestone: 1.8future

Changed 6 years ago by bill

Attachment: fieldset2.patch added

patch against latest code

comment:11 Changed 6 years ago by bill

Milestone: future1.9
Owner: changed from dante to bill
Status: newassigned
Type: enhancementfeature

comment:12 Changed 6 years ago by bill

Resolution: fixed
Status: assignedclosed

In [30990]:

Implement collapsible Fieldset widget, based on initial code from Jens Arps (CLA on file), thanks! Fixes #10171. Not sure if this should go in dijit or dijit/form though. Put it in dijit/ for now.

Note: See TracTickets for help on using tickets.