Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1017 closed defect (fixed)

Select widget doesn't work for Chinese/Japanese (FF)

Reported by: bill Owned by: liucougar
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

From Dou:

hi, i encounter the chinese character input problem in using ComboBox? widget(in remote mode), in english character it work ok. but when i input chinese characters, i notice it did not send search request to remote server(using livehttpheaders), and i found it did not trigger the _handleKeyEvents method of the ComboBox? at all.

i test with firefox 1.5 in windows XP.

BTW, the same problem did not exist in IE, but when i input chinese, it sometimes get stalled after server return the search results

From Bill:

I can't even switch to Japanese input mode on Firefox. Seemed to be working on IE though.

I checked in test_SelectJapanese.html as a test

Attachments (1)

1017.patch (1.1 KB) - added by liucougar 13 years ago.

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by liucougar

Attachment: 1017.patch added

comment:1 Changed 13 years ago by liucougar

Owner: changed from anonymous to liucougar
Status: newassigned

In FF, commiting from an input method does not trigger a keypress/keydown event, only a keyup event

The patch added compositionEnd handler for FF to trigger _handleKeyEvents

BTW: Bill, please convert test_SelectJapanese.html to UTF-8, so that I can add some Chinese there as well

comment:2 Changed 13 years ago by liucougar

in file src/widget/Select.js, function onKeyUp() is the same as its super class, so I think it can be removed

comment:3 Changed 13 years ago by bill

Milestone: 0.4
Resolution: fixed
Status: assignedclosed

Checked in as [4508]. I took out the onCompositionStart since it wasn't being used.

comment:4 Changed 13 years ago by liucougar

I retain onCompositionStart in the patch for potential future optimization of the code: in FF, after onCompositionStart, all keypress/keydown events should be ignored (they are processed by input method)

In addition, I'd like to suggest to change the comment, from:

// For Asian languages, when inputting kanji characters it 
// will generate this event instead an onKeyUp event 

to something like this:

// When inputting characters using an input method, such as Asian  
// languages, it will generate this event instead of onKeyDown event 

Because in FF, after each onCompositionEnd, an onKeyUp event is generated

comment:5 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.