Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#10167 closed defect (fixed)

combobox dropdown flickering on every keypress

Reported by: liucougar Owned by: liucougar
Priority: high Milestone: 1.4
Component: Dijit - Form Version: 1.4.0b
Keywords: Cc:
Blocked By: Blocking:

Description

  • go to dijit/tests/form/_autoComplete.html?testWidget=dijit.form.ComboBox?
  • select everything in the first dropdown
  • starts to type california

you will notice the entire page flickering on every key press, as well as the dropdown itself

Attachments (1)

10167.patch​ (4.7 KB) - added by liucougar 12 years ago.
cache wrapper (plus background iframe) in popup.js

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by liucougar

Attachment: 10167.patch​ added

cache wrapper (plus background iframe) in popup.js

comment:1 Changed 12 years ago by liucougar

Resolution: → fixed
Status: new → closed

(In [20635]) fixes #10167: cache the popup wrapper along with the iframe, so we don't need to reattach the iframe everytime an popup shows rename dijit.popup.prepare to dijit.popup.moveOffScreen

comment:2 Changed 12 years ago by liucougar

(In [20638]) refs #10167: moved getTopPopup out of open() simplified code a bit and added some comment for close()

comment:3 Changed 12 years ago by liucougar

(In [20639]) refs #10167: forgot to commit changes to _HasDropDown

comment:4 Changed 12 years ago by Adam Peller

Milestone: 1.4 → 1.4.1
Resolution: fixed
Status: closed → reopened

[20635] renamed public API dijit.popup.prepare to 'moveOffScreen' If deliberate, this should be documented in the release notes, otherwise we're probably in a situation where we must support both names.

comment:5 Changed 12 years ago by bill

Milestone: 1.4.1 → 1.4
Resolution: → fixed
Status: reopened → closed

Yes, Cougar changed that name on purpose, because the old name was confusing. I added it to the release notes.

comment:6 Changed 12 years ago by bill

(In [22236]) Fix IE focus problems in the robot tests Toolbar.html and TooltipDialog.html.

Show/hide of popups was implemented via dynamic addition/deletion of DOM nodes to the document. Those dynamic additions/deletions caused the current node to lose focus, or when the user tabs to a new field it gets focus momentarily but then focus jumps to <body>.

Best solution I could come up with was to pre-create the popup wrapper <div> and then not recycle wrapper <div> or <iframe> (although a possible optimization would be to recycle the iframe).

Fixes #10404, #11193, refs #11132, #10016, #10167 !strict.

comment:7 Changed 11 years ago by bill

Component: Dijit → Dijit - Form
Note: See TracTickets for help on using tickets.