Opened 11 years ago
Closed 9 years ago
#10163 closed defect (wontfix)
IE 8 generates onExecute event for ALL buttons, not just Submit buttons
Reported by: | drcoelho | Owned by: | |
---|---|---|---|
Priority: | high | Milestone: | tbd |
Component: | Dijit - Form | Version: | 1.3.1 |
Keywords: | button onExecute Dialog | Cc: | |
Blocked By: | Blocking: |
Description
When using dijit.form.Button from within dijit.Dialog, ALL buttons generate an onExecute event causing the dialog to hide, even when not tagged as a submit button.
Behavior is as expected in Firefox and Chrome, but is broken per above in IE version 8.
Attachments (1)
Change History (7)
comment:1 Changed 11 years ago by
Resolution: | → duplicate |
---|---|
Status: | new → closed |
comment:2 Changed 10 years ago by
Milestone: | tbd → 1.7 |
---|---|
Priority: | highest → normal |
Resolution: | duplicate |
severity: | blocker → minor |
Status: | closed → reopened |
Will check in a fix for this soon so changing status from duplicate to open.
comment:3 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
(In [24185]) Refactor parser to allow attributes (for a single node) to be partly specified in data-dojo-props, and partly specified directly ex: value=123. Uses node.attributes to detect which attributes are specified on a node, or for older versions of IE calls cloneNode(false) followed by some regex's on clone.outerHTML.
Due to lowercase/uppercase issues (ex: tabIndex, onClick), and for type conversion, the code still introspects each widget to get it's attribute metadata. In the future, would like to defer/avoid that in the common case. Fixes #10153, #12423, #12476, #10150, #9823, refs #11490 !strict.
Also fixes the problem on IE8 where a button without type=... defaults to type=submit rather than whatever the widget defines the default as, fixes #10163, refs #9334, #8946.
Future updates will be attached to ticket #12476.
comment:4 Changed 10 years ago by
Component: | Dijit → Dijit - Form |
---|
comment:5 Changed 9 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:6 Changed 9 years ago by
Milestone: | 1.7 → tbd |
---|---|
Resolution: | → wontfix |
Status: | reopened → closed |
Marking as wontfix, but see #14135, scheduled for 2.0.
You need to specify type=button on the buttons, as documented in #9334, #9152, #8946, and the release notes. type=submit is actually the standard behavior for <button> nodes according to the HTML spec.
Although dijit.form.Button does defines the default type to be button, there's a parser problem where it needs to be specified explicitly on the <button> node too.