Opened 9 years ago

Closed 7 years ago

#10163 closed defect (wontfix)

IE 8 generates onExecute event for ALL buttons, not just Submit buttons

Reported by: drcoelho Owned by:
Priority: high Milestone: tbd
Component: Dijit - Form Version: 1.3.1
Keywords: button onExecute Dialog Cc:
Blocked By: Blocking:

Description

When using dijit.form.Button from within dijit.Dialog, ALL buttons generate an onExecute event causing the dialog to hide, even when not tagged as a submit button.

Behavior is as expected in Firefox and Chrome, but is broken per above in IE version 8.

Attachments (1)

button.html (611 bytes) - added by bill 7 years ago.
test case

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by bill

Resolution: duplicate
Status: newclosed

You need to specify type=button on the buttons, as documented in #9334, #9152, #8946, and the release notes. type=submit is actually the standard behavior for <button> nodes according to the HTML spec.

Although dijit.form.Button does defines the default type to be button, there's a parser problem where it needs to be specified explicitly on the <button> node too.

comment:2 Changed 8 years ago by bill

Milestone: tbd1.7
Priority: highestnormal
Resolution: duplicate
severity: blockerminor
Status: closedreopened

Will check in a fix for this soon so changing status from duplicate to open.

comment:3 Changed 8 years ago by bill

Resolution: fixed
Status: reopenedclosed

(In [24185]) Refactor parser to allow attributes (for a single node) to be partly specified in data-dojo-props, and partly specified directly ex: value=123. Uses node.attributes to detect which attributes are specified on a node, or for older versions of IE calls cloneNode(false) followed by some regex's on clone.outerHTML.

Due to lowercase/uppercase issues (ex: tabIndex, onClick), and for type conversion, the code still introspects each widget to get it's attribute metadata. In the future, would like to defer/avoid that in the common case. Fixes #10153, #12423, #12476, #10150, #9823, refs #11490 !strict.

Also fixes the problem on IE8 where a button without type=... defaults to type=submit rather than whatever the widget defines the default as, fixes #10163, refs #9334, #8946.

Future updates will be attached to ticket #12476.

comment:4 Changed 8 years ago by bill

Component: DijitDijit - Form

comment:5 Changed 7 years ago by bill

Resolution: fixed
Status: closedreopened

Turns out this wasn't fixed by [24185], and I don't see any way to fix it. I filed #14135 so at least there won't be a discrepancy of behavior between browsers.

comment:6 Changed 7 years ago by bill

Milestone: 1.7tbd
Resolution: wontfix
Status: reopenedclosed

Marking as wontfix, but see #14135, scheduled for 2.0.

Changed 7 years ago by bill

Attachment: button.html added

test case

Note: See TracTickets for help on using tickets.