Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1015 closed defect (fixed)

DomWidget: No longer able to hard-code templateCssString

Reported by: scott.severtson@… Owned by: dylan
Priority: high Milestone:
Component: Widgets Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

From revision 4074 http://trac.dojotoolkit.org/changeset/4074 forward, Widgets can no longer include hard-coded CSS by templateCssString value as part of their definition. This functionality can make sense for very small CSS fragments, reducing total number of server requests, etc.

Suggested patch: DomWidget?.js: 49-60 of Revision 4467:

if((cpath && !dojo.widget._cssFiles[cpath.toString()])
objtemplateCssString?){

if((!obj.templateCssString)&&(cpath)){

obj.templateCssString = dojo.hostenv.getText(cpath); obj.templateCssPath = null;

} if((objtemplateCssString?)&&(!obj.templateCssStringloaded?)){

dojo.style.insertCssText(obj.templateCssString, null, cpath); if(!obj.templateCssString){ obj.templateCssString = ""; } obj.templateCssString.loaded = true;

} if(cpath){

dojo.widget._cssFiles[cpath.toString()] = true;

}

}

Thanks,

Scott Severtson Digital Measures LLC

Change History (4)

comment:1 Changed 13 years ago by dylan

Milestone: 0.4
Owner: changed from anonymous to dylan
Status: newassigned

Scott, we really appreciate your patch. Unfortunately, we need a CLA on file before we can accept any code contributions. More information is available at http://dojotoolkit.org/foundation/ . Thanks, -Dylan

comment:2 Changed 13 years ago by liucougar

I think this is a duplicate ticket of #1029

it should have been fixed in r4659

comment:3 Changed 13 years ago by dylan

Resolution: fixed
Status: assignedclosed

comment:4 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.