Regression: IE: Clicking iframe scrollbar in editor causes the content to jump to the bottom

[Jared Jurkiewicz]

IE: Clicking iframe scrollbar in editor causes the content to jump to the bottom

This is really ugly and makes it hard to use the scrollbar to scroll IE editor content.

[Jared Jurkiewicz]

Testcase showing it. Just click the scrollbar handle for editor and watch it jump

[Jared Jurkiewicz]

Problem occurs in: 1.3, 1.4b1

Does NOT occur in: 1.2

[Jared Jurkiewicz]

This is caused by the introduction of the following in 1.3:

dijit/Editor.js:

_onIEMouseDown: function(/*Event*/ e){

summary: IE only to prevent 2 clicks to focus tags: private delete this._savedSelection; new mouse position overrides old selection if(e.target.tagName == "BODY"){

setTimeout(dojo.hitch(this, "placeCursorAtEnd"), 0);

} this.inherited(arguments);

},

That setTimeout to shift the body to the end causes the scrollers to glitch horribly.

Does anyone know why that was added?

[Jared Jurkiewicz]

That was you Doug!

16555 doughays delete this._savedSelection; new mouse position overrides old selection

16555 doughays if(e.target.tagName == "BODY"){ 16555 doughays setTimeout(dojo.hitch(this, "placeCursorAtEnd"), 0); 16555 doughays } 16555 doughays this.inherited(arguments); 16555 doughays },

[Jared Jurkiewicz]

Caused by: ​http://bugs.dojotoolkit.org/changeset/16555

Is it necessary to scroll it to the end? Or was that just something you did because you thought it would help?

[Jared Jurkiewicz]

I see, it was probably to fix that editor click empty regression. Oof. Well, I think I have a fix for it. Check that the click was within clientwidth/clientHeight of target if it was body. If it was, then it wasn't a scroller. Scrollbar x/y are outside clientWidth/height. Though ... I also need to check if it is scrolled and add that too. Hm

[Jared Jurkiewicz]

Assigning to you, Doug, for review. (Since you broke it!).

Does this seem reasonable as a fix?

[Jared Jurkiewicz]

Potential patch for trying to identify click events on scrollers or on body.

[Douglas Hays]

(In [20597]) Fixes #10126. Ignore mouse down events in IE that are outside the actual editing area.