Opened 10 years ago

Closed 4 years ago

#10118 closed defect (patchwelcome)

[patch][cla] timesince filter fails if delta < 60000

Reported by: Mark Wubben Owned by:
Priority: low Milestone: 1.13
Component: DojoX DTL Version: 1.4.0b
Keywords: Cc: Neil Roberts
Blocked By: Blocking:

Description

The timesince filter in DTL (dojox.dtl.utils.date) fails if the delta is less than 60000. I've attached a patch that adds precision up to 1 second.

Attachments (1)

dojox.dtl.utils.date.js.r16700.diff (1.0 KB) - added by Mark Wubben 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by Mark Wubben

comment:1 Changed 10 years ago by dante

Milestone: tbd1.5
Summary: [patch[cla] timesince filter fails if delta < 60000[patch][cla] timesince filter fails if delta < 60000

comment:2 Changed 9 years ago by bill

Milestone: 1.51.6

1.5 is released, moving remaining tickets to 1.6

comment:3 Changed 8 years ago by bill

Milestone: 1.6future

(sadly) punting seemingly abandoned ticket and meta tickets to future

comment:4 Changed 7 years ago by ben hockey

Owner: changed from Neil Roberts to Mark Wubben
Priority: highlow
Status: newpending

mark, do you have a test page to demonstrate this? i'm going through old dtl tickets and applying any working patches. it would help to have a page that shows the error fixed by this patch.

comment:5 Changed 7 years ago by Mark Wubben

Owner: changed from Mark Wubben to ben hockey
Status: pendingassigned

Afraid I don't. Haven't used DTL in ages…

comment:6 Changed 7 years ago by ben hockey

Owner: ben hockey deleted
Status: assignedopen

comment:7 Changed 4 years ago by dylan

Milestone: future1.12
Resolution: patchwelcome
Status: openclosed

Given the lack of attention that dojox/dtl has received, I'm closing this ticket as patchwelcome. If you would like to work on a fix, please create a pull request and reopen the ticket.

Note: See TracTickets for help on using tickets.