Opened 10 years ago

Closed 6 years ago

#10094 closed defect (wontfix)

spacing on inline type declarations

Reported by: bill Owned by: bill
Priority: high Milestone: future
Component: CheckStyle Version: 1.4.0b
Keywords: Cc:
Blocked By: Blocking:

Description

I think it should be flagging and converting:

/*DomNode*/node

into

/*DomNode*/ node

(with a space)

Also, I think it should be removing spaces inside the comment, for example:

/* DomNode */ node

Change History (6)

comment:1 Changed 10 years ago by Shane O'Sullivan

Milestone: tbd1.5

Right now I can't see how to do this effectively, without affecting other comments. Perhaps do this to all inline comments?

Either way, this can be punted to after 1.4 I think

comment:2 Changed 10 years ago by bill

Yeah, it seems difficult to me too. I thought about doing it to all C-style /* ... */ comments since our real comments use the C++ // style, but I'm sure we occasionally use /* ... */ to comment out blocks of code. Maybe just search for the pattern /\* [a-zA-Z\[\]\?]+ \*/ (comments that just contain a single word) as that will catch 99% of them?

comment:3 Changed 9 years ago by Adam Peller

Milestone: 1.51.6

comment:4 Changed 8 years ago by bill

Milestone: 1.6future

(sadly) punting seemingly abandoned ticket and meta tickets to future

comment:5 Changed 6 years ago by dylan

Owner: changed from Shane O'Sullivan to bill
Status: newassigned

Bill, is this still something we should keep open?

comment:6 Changed 6 years ago by bill

Resolution: wontfix
Status: assignedclosed

Let's close it, Shane isn't working on Dojo anymore.

Note: See TracTickets for help on using tickets.