Opened 11 years ago
Closed 11 years ago
#10093 closed defect (fixed)
backslashes doubled
Reported by: | bill | Owned by: | Shane O'Sullivan |
---|---|---|---|
Priority: | high | Milestone: | 1.4 |
Component: | CheckStyle | Version: | 1.4.0b |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
In files like _RichText.js, the style correction will convert \ into
,
into
, etc.
Change History (5)
comment:1 Changed 11 years ago by
Status: | new → assigned |
---|
comment:2 Changed 11 years ago by
comment:3 Changed 11 years ago by
I just grabbed the latest code. Here's what I did:
- run "sh checkstyle.sh"
- open checkstyleReport.html
- click dijit/_editor in left hand column
- click first "Richtext.js" entry in right grid
- click "make fixes" button
- click "save" button
Now comparing _Richtext.js to _Richtext.js.checkstyle.js:
old:
"\\": exec("insertunorderedlist")
vs. new:
"\\\\": exec("insertunorderedlist")
And so on.
This was running on mac, and using safari, although I doubt that makes a difference.
This was running against RichText.js [20573], I'm about to check in some fixes to that file that may affect the results so you should try running against that version.
comment:4 Changed 11 years ago by
(In [20595]) Refs #10093 Fixes the issue where the Checkstyle tool failed to correctly handle backslashes in front of quotes and double quotes. This was caused by the PHP file used to save modified JavaScript? files, which had code that manipulated the file contents to remove unnecessary backslashes. The solution is to use the stripslashes() PHP function instead.
comment:5 Changed 11 years ago by
Milestone: | tbd → 1.4 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
I can not replicate this issue on the latest code. Can you please retest, and close this ticket if it is no longer a problem?