#10073 closed defect (fixed)
TreeGrid: double-click on expando causes error
Reported by: | Nathan Toone | Owned by: | Karl Tiedt |
---|---|---|---|
Priority: | high | Milestone: | 1.6.2 |
Component: | DojoX Grid | Version: | 1.6.1 |
Keywords: | Cc: | Evan | |
Blocked By: | Blocking: |
Description
Run any treegrid test and double-click on an expando to get the error this._click[0] is undefined.
Change History (12)
comment:1 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 10 years ago by
I am still seeing this bug in 1.6, where this._click[0] ends up being null or undefined so trying to access .rowIndex throws an error
Would you object to making the onCellClick (where this propagates from) read like this
onCellClick: function(e){ // summary: // Event fired when a cell is clicked. // e: Event // Decorated event object which contains reference to grid, cell, and rowIndex this._click[0] = this._click[1]; this._click[1] = e; if(!this.edit.isEditCell(e.rowIndex, e.cellIndex)){ this.focus.setFocusCell(e.cell, e.rowIndex); } // prevent null events from propagating as double clicks if(this._click[0] == null) { this._click.shift(); } this.onRowClick(e); },
comment:3 Changed 10 years ago by
Milestone: | 1.4 |
---|---|
Resolution: | fixed |
Status: | closed → reopened |
Version: | 1.3.2 → 1.6.1 |
Going to reopen this to apply more definitive patch since this bug is still reproducible in 1.6
comment:4 Changed 10 years ago by
Owner: | changed from Nathan Toone to Karl Tiedt |
---|---|
Status: | reopened → new |
comment:5 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:6 Changed 10 years ago by
Milestone: | → tbd |
---|
comment:7 follow-up: 8 Changed 10 years ago by
Cc: | evan added |
---|---|
Milestone: | tbd → 1.7 |
patch is in the pipeline for 1.7. Did you want this to be considered for backporting?
comment:8 Changed 10 years ago by
comment:11 Changed 10 years ago by
Milestone: | 1.7 → 1.6.2 |
---|
comment:12 Changed 10 years ago by
Cc: | Evan added; evan removed |
---|
Note: See
TracTickets for help on using
tickets.
(In [20516]) Fixes #10073 - prevent crash when double-clicking on expando !strict