TreeGrid: double-click on expando causes error

[Nathan Toone]

Run any treegrid test and double-click on an expando to get the error this._click[0] is undefined.

[Nathan Toone]

(In [20516]) Fixes #10073 - prevent crash when double-clicking on expando !strict

[Karl Tiedt]

I am still seeing this bug in 1.6, where this._click[0] ends up being null or undefined so trying to access .rowIndex throws an error

Would you object to making the onCellClick (where this propagates from) read like this

	onCellClick: function(e){
		// summary:
		//		Event fired when a cell is clicked.
		// e: Event
		//		Decorated event object which contains reference to grid, cell, and rowIndex
		this._click[0] = this._click[1];
		this._click[1] = e;
		if(!this.edit.isEditCell(e.rowIndex, e.cellIndex)){
			this.focus.setFocusCell(e.cell, e.rowIndex);
		}
		// prevent null events from propagating as double clicks
		if(this._click[0] == null) { this._click.shift(); }
		this.onRowClick(e);
	},

[Karl Tiedt]

Going to reopen this to apply more definitive patch since this bug is still reproducible in 1.6

[Karl Tiedt]

(In [25141]) fixes #10073 - click[0] was sometimes hitting nulls which caused this error to still come up

[Adam Peller]

patch is in the pipeline for 1.7. Did you want this to be considered for backporting?

[Karl Tiedt]

Replying to peller:

patch is in the pipeline for 1.7. Did you want this to be considered for backporting?

Yes please, as well as #11188 if you can Evan

[Adam Peller]

[25140] was ktiedt's checkin to fix this bug

[evan]

Backported to 1.6 branch with [25157]