Opened 10 years ago

Closed 9 years ago

#10050 closed defect (duplicate)

[patch] [cla] dojo.date.locale.format doesn't honor double single quotes

Reported by: nqzero Owned by: Adam Peller
Priority: high Milestone: 1.5
Component: Date Version: 1.3.2
Keywords: datePattern single quote Cc:
Blocked By: Blocking:

Description

dojo.date.locale.format claims:

split on single quotes (which escape literals in date format ... but preserve escaped single quotes (e.g., oclock)

but it doesn't work correctly - it leaves the double single quotes in place instead of replacing them with a single single quote.

Attachments (2)

dojo.datePattern.patch (1.3 KB) - added by nqzero 10 years ago.
a patch that corrects the handling of double single quotes
quote.patch (2.6 KB) - added by Adam Peller 9 years ago.
Updated patch for style and included tests. Does not pass tests.

Download all attachments as: .zip

Change History (7)

Changed 10 years ago by nqzero

Attachment: dojo.datePattern.patch added

a patch that corrects the handling of double single quotes

comment:1 Changed 10 years ago by bill

Component: GeneralDate
Owner: changed from anonymous to Adam Peller
Summary: dojo.date.locale.format doesn't honor double single quotes[patch] [no cla] dojo.date.locale.format doesn't honor double single quotes

Seth, thanks for the patch but can you file a http://dojofoundation.org/cla/? We can't use the patch without one.

comment:2 Changed 9 years ago by nqzero

Aimee Evans wrote:

This email confirms that your Contributor License Agreement has been received and your name has been added to the Dojo Foundation's contributor listing.

comment:3 Changed 9 years ago by Adam Peller

Summary: [patch] [no cla] dojo.date.locale.format doesn't honor double single quotes[patch] [cla] dojo.date.locale.format doesn't honor double single quotes

Thanks, Seth, for the CLA and the patch. Can you provide a test case which this should fix? I uncommented out what I think should work in our tests and it didn't seem to work. I don't have much time to look into this right now, so if you have any suggestions or refinements, please let me know. I updated the patch for style changes and included the test changes.

Changed 9 years ago by Adam Peller

Attachment: quote.patch added

Updated patch for style and included tests. Does not pass tests.

comment:4 Changed 9 years ago by Adam Peller

Milestone: 1.41.5

comment:5 Changed 9 years ago by Adam Peller

Resolution: duplicate
Status: newclosed

Dup of #10554

Note: See TracTickets for help on using tickets.