Opened 10 years ago
Closed 10 years ago
#10050 closed defect (duplicate)
[patch] [cla] dojo.date.locale.format doesn't honor double single quotes
| Reported by: | nqzero | Owned by: | Adam Peller |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5 |
| Component: | Date | Version: | 1.3.2 |
| Keywords: | datePattern single quote | Cc: | |
| Blocked By: | Blocking: |
Description
dojo.date.locale.format claims:
split on single quotes (which escape literals in date format ... but preserve escaped single quotes (e.g., oclock)
but it doesn't work correctly - it leaves the double single quotes in place instead of replacing them with a single single quote.
Attachments (2)
Change History (7)
Changed 10 years ago by
| Attachment: | dojo.datePattern.patch added |
|---|
comment:1 Changed 10 years ago by
| Component: | General → Date |
|---|---|
| Owner: | changed from anonymous to Adam Peller |
| Summary: | dojo.date.locale.format doesn't honor double single quotes → [patch] [no cla] dojo.date.locale.format doesn't honor double single quotes |
Seth, thanks for the patch but can you file a http://dojofoundation.org/cla/? We can't use the patch without one.
comment:2 Changed 10 years ago by
Aimee Evans wrote:
This email confirms that your Contributor License Agreement has been received and your name has been added to the Dojo Foundation's contributor listing.
comment:3 Changed 10 years ago by
| Summary: | [patch] [no cla] dojo.date.locale.format doesn't honor double single quotes → [patch] [cla] dojo.date.locale.format doesn't honor double single quotes |
|---|
Thanks, Seth, for the CLA and the patch. Can you provide a test case which this should fix? I uncommented out what I think should work in our tests and it didn't seem to work. I don't have much time to look into this right now, so if you have any suggestions or refinements, please let me know. I updated the patch for style changes and included the test changes.
Changed 10 years ago by
| Attachment: | quote.patch added |
|---|
Updated patch for style and included tests. Does not pass tests.
comment:4 Changed 10 years ago by
| Milestone: | 1.4 → 1.5 |
|---|
a patch that corrects the handling of double single quotes