Opened 11 years ago
Closed 8 years ago
#10032 closed defect (patchwelcome)
Use sprites in dojox.editor.plugins.Smiley
Reported by: | Adam Peller | Owned by: | Adam Peller |
---|---|---|---|
Priority: | high | Milestone: | 1.9 |
Component: | Editor | Version: | 1.3.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Instead of individual images, the sprite technique should be used.
Change History (6)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
This was part of the code in #10562 (see 5x4.gif attachment there), although I didn't check it in because it loses the animation.
comment:3 Changed 8 years ago by
Milestone: | future → 1.9 |
---|
We should resolve this for 1.9. My guess is wontfix? peller or bill?
comment:4 Changed 8 years ago by
I guess wontfix unless peller wants to change it. Of course it would be a nice performance improvement, but it would take a bit of work, especially since the icons are displayed not just in the dropdown, but also within the editor's iframe (along with the text).
comment:5 Changed 8 years ago by
I agree it would be nice to have. I will not be able to get to it for 1.9. patchwelcome or wontfix?
comment:6 Changed 8 years ago by
Component: | Dojox → Editor |
---|---|
Resolution: | → patchwelcome |
Status: | new → closed |
I would welcome a patch.
will require addition of text nodes to support high contrast mode, as done with toolbar buttons