Do not pick up non-string literal dojo.require calls in the build system.

[James Burke]

buildUtil.getDependencyList needs to change its regexp to only pick up ["']value["'] matches.

Check uses of buildUtil.masterDependencyRegExpString, buildUtilXd needs to change too.

[ole]

I was hoping it would work like this:

dojo.require(clazz);

--Check to see whether clazz can be loaded.

--If so include it as a dependency in the layer

--If not just ignore it.

This would enable this:

dojo.declare("com.my.Class", null
{
    A_CONSTANT_CLASS_DEFINITION: "com.my.other.SomeOtherClass";
    constructor: function()
    {
        dojo.require(this.A_CONSTANT_CLASS_DEFINITION);
    }
}

This would avoid having to dojo.require("com.my.other.SomeOtherClass?"); at the top of the class definition as well.

[bill]

Bulk update to assign BuildSystem? tickets to Rawld. Many of these are probably already fixed in 1.7.

[ben hockey]

i'd say this should be closed as wontfix

[bill]

Assuming that the current build system doesn't choke on something like below, we can close this as fixed in 1.7:

var foo = "dijit/form/DateTextBox";
define([foo], function(){ ... });

(I wouldn't expect it to put dijit/form/DateTextBox into the build but at least it shouldn't crash.)

[Rawld Gill]

We're trying to get our of regex hell with build system. Also AMD gives you exactly the feature you are looking for:

// the module my/subclass
define(["my/superclass"], function(super){
  return dojo.declare([super], {
    // etc.
  });
});