Opened 11 years ago
Closed 8 years ago
#10015 closed enhancement (fixed)
robot: improve mouse interaction with iframes
Reported by: | haysmark | Owned by: | haysmark |
---|---|---|---|
Priority: | low | Milestone: | 1.4 |
Component: | TestFramework | Version: | 1.3.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
See: http://archive.dojotoolkit.org/nightly/checkout/dijit/tests/editor/robot/Editor_mouse.html
The test double clicks in the center of the Editor to select the text and delete all of it. The problem is that is the full extent of the robot's ability to interact with the Editor; if you tell the robot to point the mouse at text inside the Editor (the text is in an iframe) it will fail to move the mouse over the text.
We could write more robust tests for Editor if the robot could click through iframes.
Attachments (1)
Change History (12)
Changed 11 years ago by
Attachment: | 10015.patch added |
---|
comment:1 Changed 11 years ago by
Milestone: | tbd → 1.4 |
---|
comment:2 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 11 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Guys, this new Editor_iframe.html robot test is failing for me on IE6, IE8, and FF3.5/win. (It does work on chrome for me.) The test also has hundreds of lines of copied code from Editor_mouse.html, which is a maintenance problem. But most importantly, this test doesn't seem to be a test of Editor at all, it's a test of DOH's scrollIntoView().
If you want to test the new DOH functionality please add the test to the doh/ directory instead.
If you want to test editor/mouse interaction, for example using the mouse to position the caret at a certain position, or to select certain text in the editor, feel free to add those tests to the existing Editor_mouse.html.
Thanks.
comment:4 Changed 11 years ago by
comment:5 Changed 11 years ago by
Milestone: | 1.4 → 1.5 |
---|
comment:6 Changed 11 years ago by
Milestone: | 1.5 → 1.6 |
---|
comment:7 Changed 10 years ago by
comment:9 Changed 10 years ago by
Milestone: | 1.6 → future |
---|
(sadly) punting seemingly abandoned ticket and meta tickets to future
comment:10 Changed 9 years ago by
Keywords: | needsreview added |
---|---|
Priority: | high → low |
comment:11 Changed 8 years ago by
Keywords: | needsreview removed |
---|---|
Milestone: | future → 1.4 |
Resolution: | → fixed |
Status: | reopened → closed |
I guess this is actually fixed, except for the test case. I'll just close it.
Fixes #10015. Added new robot logic for clicking nodes inside nested iframes. Added new Editor tests.