Opened 10 years ago

Closed 7 years ago

#10015 closed enhancement (fixed)

robot: improve mouse interaction with iframes

Reported by: haysmark Owned by: haysmark
Priority: low Milestone: 1.4
Component: TestFramework Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

See: http://archive.dojotoolkit.org/nightly/checkout/dijit/tests/editor/robot/Editor_mouse.html

The test double clicks in the center of the Editor to select the text and delete all of it. The problem is that is the full extent of the robot's ability to interact with the Editor; if you tell the robot to point the mouse at text inside the Editor (the text is in an iframe) it will fail to move the mouse over the text.

We could write more robust tests for Editor if the robot could click through iframes.

Attachments (1)

10015.patch (18.0 KB) - added by haysmark 10 years ago.
Fixes #10015. Added new robot logic for clicking nodes inside nested iframes. Added new Editor tests.

Download all attachments as: .zip

Change History (12)

Changed 10 years ago by haysmark

Attachment: 10015.patch added

Fixes #10015. Added new robot logic for clicking nodes inside nested iframes. Added new Editor tests.

comment:1 Changed 10 years ago by Douglas Hays

Milestone: tbd1.4

comment:2 Changed 10 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [20453]) Fixes #10015 !strict. Proxy commit for haysmark (CCLA on file). Add multi-iframe scrollIntoView into robot API for dijit. Add editor test that makes use of the new API.

comment:3 Changed 10 years ago by bill

Resolution: fixed
Status: closedreopened

Guys, this new Editor_iframe.html robot test is failing for me on IE6, IE8, and FF3.5/win. (It does work on chrome for me.) The test also has hundreds of lines of copied code from Editor_mouse.html, which is a maintenance problem. But most importantly, this test doesn't seem to be a test of Editor at all, it's a test of DOH's scrollIntoView().

If you want to test the new DOH functionality please add the test to the doh/ directory instead.

If you want to test editor/mouse interaction, for example using the mouse to position the caret at a certain position, or to select certain text in the editor, feel free to add those tests to the existing Editor_mouse.html.

Thanks.

comment:4 Changed 10 years ago by bill

(In [20663]) Please add tests of robot into unit tests for robot itself, rather than into tests for editor. Refs #10015.

comment:5 Changed 10 years ago by Douglas Hays

Milestone: 1.41.5

comment:6 Changed 9 years ago by Adam Peller

Milestone: 1.51.6

comment:7 Changed 9 years ago by bill

(In [22987]) On Chrome 6 on Windows, the delete key is no longer deleting the space before the highlighted word. At least for me. Refs #10015.

comment:8 Changed 9 years ago by Douglas Hays

(In [23004]) Refs #10015. Delete unused test file.

comment:9 Changed 9 years ago by bill

Milestone: 1.6future

(sadly) punting seemingly abandoned ticket and meta tickets to future

comment:10 Changed 8 years ago by ben hockey

Keywords: needsreview added
Priority: highlow

comment:11 Changed 7 years ago by bill

Keywords: needsreview removed
Milestone: future1.4
Resolution: fixed
Status: reopenedclosed

I guess this is actually fixed, except for the test case. I'll just close it.

Note: See TracTickets for help on using tickets.