Opened 10 years ago

Closed 10 years ago

#10007 closed defect (fixed)

TabContainer: Renaming tab titles doesn't trigger new scroll button enabling

Reported by: mark007 Owned by: Shane O'Sullivan
Priority: high Milestone: 1.4
Component: Dijit Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

Hi,

Again I am working with many tabs, using the nightly build of 1.4 from 1st Oct. If I have say 4 small tabs, which probably fills 50% the width of my tabcontainer width, there is no need for the scroll left / right buttons.

This is fine, but when I rename all four with javascript, the tabcontainer doesn't seem to recalculate if it needs scroll buttons. In my case, I usually start with small titles, renaming later to much larger ones, which I can repeatedly show the problem.

I guess the solution is to recalculate whether tab scroll buttons are needed, on more events like title change, and closable / not closable change.

Change History (5)

comment:1 Changed 10 years ago by bill

Owner: set to Shane O'Sullivan

Similar to #9956 but apparently different, since that ticket is already fixed.

comment:2 Changed 10 years ago by mark007

Yeah that ticket related to the scrolling of the tabs, but this one relates to the enabling / disabling of the tab scroll buttons. They don't seem to enable (when currently disabled) when titles get updated and hence increase tab widths beyond width of tab container.

Thanks for the other fixes, really love this piece of work, cheers Shane.

comment:3 Changed 10 years ago by Shane O'Sullivan

Status: newassigned

comment:4 Changed 10 years ago by Shane O'Sullivan

(In [20596]) Refs #10007 Fixes the issue where, if the existing tabs on a TabContainer? are less than the full width of the TabContainer?, then one is renamed to a longer label such that the tabs are then wider than the TabContainer?, the buttons for sliding the tabs do not appear.

comment:5 Changed 10 years ago by Shane O'Sullivan

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.