Opened 10 years ago

Closed 7 years ago

#10006 closed defect (worksforme)

_CheckedMultiSelectItem should not capture "onmousedown" event

Reported by: avoidscorn Owned by:
Priority: high Milestone: future
Component: DojoX Form Version: 1.3.2
Keywords: Cc:
Blocked By: Blocking:

Description

The _CheckedMultiSelectItem class forwards mouse events ("onmousedown", "onmouseover", "onmouseout") from its label node to its CheckBox widget. However the CheckBox widget itself only captures "onmouseover" and "onmouseout" events.

By capturing the "onmousedown" event, it prevents a dijit.Menu bound to the CheckedMultiSelect domNode from working properly when the user right-clicks on a _CheckedMultiSelectItem label.

Attachments (1)

test_CheckedMultiSelect_Menu.html (1.6 KB) - added by avoidscorn 10 years ago.
Test Case (run from dojox/form/tests folder)

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by dante

Owner: changed from dante to Nathan Toone

comment:2 Changed 10 years ago by Nathan Toone

Milestone: tbdfuture

Could you please post a test case? I'm not sure what you mean "prevents a dijit.Menu bound to the node from working properly".

Changed 10 years ago by avoidscorn

Test Case (run from dojox/form/tests folder)

comment:3 Changed 10 years ago by avoidscorn

If you run the test case above, you will not be able to right-click on a checkbox label and then select a menu item from the context menu with the mouse.

If you remove the "onmousedown" event from the _CheckedMultiSelectItem.html template, the problem goes away with AFAICT no loss of functionality on the CheckedMultiSelect widget.

comment:4 Changed 10 years ago by Nathan Toone

Milestone: future1.5

I can take a look at this - but it is a bit too close to the cutoff date for 1.4.

comment:5 Changed 9 years ago by Nathan Toone

Milestone: 1.5future
Owner: Nathan Toone deleted

Moving my tickets to future, as I am not currently working on them.

comment:6 Changed 7 years ago by haysmark

Resolution: worksforme
Status: newclosed
Note: See TracTickets for help on using tickets.