Opened 10 years ago

Closed 10 years ago

#10003 closed task (fixed)

dojo.hash requires better tests

Reported by: miksago Owned by: Rob Retchless
Priority: high Milestone: 1.4
Component: General Version: 1.4.0b
Keywords: Cc: micheil@…, Rob Retchless
Blocked By: Blocking:

Description

Currently all the tests that are run on dojo.hash are within one test case, meaning if one sort of test fails, then the whole lot do, and there's no way of finding out what is specifically failing.

Attachments (2)

hash.js (5.8 KB) - added by miksago 10 years ago.
Proposed patch (revised the pubsub test.)
hash.2.js (6.3 KB) - added by miksago 10 years ago.
Proposed patch (Added tests for "extra#instring")

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by Adam Peller

Cc: Rob Retchless added
Owner: changed from anonymous to miksago

comment:2 Changed 10 years ago by dante

Milestone: 1.4future
severity: majornormal
Version: 1.4.0b

Changed 10 years ago by miksago

Attachment: hash.js added

Proposed patch (revised the pubsub test.)

Changed 10 years ago by miksago

Attachment: hash.2.js added

Proposed patch (Added tests for "extra#instring")

comment:3 Changed 10 years ago by Adam Peller

Milestone: future1.5

miksago - thanks for the patch. Rob, should we try to get this in 1.4? There isn't much time.

comment:4 Changed 10 years ago by Adam Peller

Milestone: 1.51.4
Owner: changed from miksago to Rob Retchless

comment:5 Changed 10 years ago by Rob Retchless

The extra#instring test fails in IE6 because it forcibly removes any extra hashes. To support this across browsers, it must be encoded, so there's no point in having a test for it. The first patch looks awesome though, with one small tweak required to the trailingSpace test. I'll make a patch and get it in today.

comment:6 Changed 10 years ago by Adam Peller

Resolution: fixed
Status: newclosed

Fixed in [20829] with tweaks. Thanks, Mikheil!

Note: See TracTickets for help on using tickets.