Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#10001 closed defect (fixed)

Calendar incremental change event handling

Reported by: Adam Peller Owned by: bill
Priority: high Milestone: 1.6
Component: Dijit Version: 1.3.2
Keywords: Cc: David Schwartz, becka11y
Blocked By: Blocking:

Description (last modified by bill)

Decide whether keyboard events change the value and result in onChange events or are treated more like mouse hover events and accepted only when ENTER is hit. The latter would be awkward for a standalone widget.

Also consider using consistent handling and APIs with ColorPalette.

Change History (9)

comment:1 Changed 10 years ago by Adam Peller

Cc: David Schwartz added; drs removed

comment:2 Changed 9 years ago by Adam Peller

Milestone: 1.51.6

comment:3 Changed 9 years ago by bill

Description: modified (diff)
Owner: changed from Adam Peller to bill
Status: newassigned

Talked to Becky about this. Working like ColorPalette, where ENTER/SPACE needed for selection, seems to be the only way to support navigating disabled dates. That's to say that arrow keys need to navigate onto the disabled dates,and it would be awkward to let a user select a date that was disabled.

comment:4 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [22665]) Calendar: separate focus and selection handling, so that (like ColorPalette and Tree), arrow keys navigate and ENTER/SPACE selects the date (fixes #10001 !strict). This allows navigation across disabled dates (refs #6430, fixes #11484), and completes keyboard support for DateTextBox, although it still needs screen reader work (refs #9918).

Also seems to have fixed the ctrl-page-up/down problem on FF/mac (fixes #11483).

Also merged in Calendar.set("value", ..., priorityChange) support from neonstalwart (fixes #11331), thanks!

comment:5 Changed 9 years ago by bill

(In [22682]) Fix tabIndex setting (should have tabIndex on exactly one cell at all times), refs #10001 !strict.

comment:6 Changed 9 years ago by bill

(In [22731]) test update related to Calendar focus changes, refs #10001

comment:7 Changed 9 years ago by bill

(In [22732]) fix tabbing, refs #10001

comment:8 Changed 9 years ago by bill

(In [22746]) [22731] assumed that the DateTextBox? would go to the 17th of the month, but actually it goes to the current day (because there's no entry in the <input> box). Refs #10001.

comment:9 Changed 9 years ago by bill

(In [22763]) Eliminate race condition in DOH test where a DateTextBox.set() call (which fires an onChange event) is immediately followed by changes=[]... it assumed that the onChange fires instantly when really it's done on a setTimeout().

Also fixed a real bug where onChange() was getting called when it shouldn't be, through the Calendar.

Refs #10001 !strict.

Note: See TracTickets for help on using tickets.