Custom Query (18300 matches)

The tree code has an IE break. Trailing comma. Line: 268

var childParams=dojo.map(items, function(item){

return {

item: item, isExpandable: this.mayHaveChildren(item),

};

}, this);

This is poor. This was easily catchable if any of the tree tests were run on IE, or tools like JSLint were run against the code before checkin.

1.0: Add identity support to OpmlStore?

Simple identity support to OpmlStore?, where the item # is its identity.

1.0: dojo.data.util.simpleFetch mixin isn't passing null to onComplete when onItem is being used.

This is a minor spec deviation that needs to be fixed. The API states that if the onItem callback is passed, then onComplete will be passed a null for the items array. This is because onItem callback setting assumes streaming approach to data handling whereas onComplete is chunked. You use one or the other. In the case of onItem, onComplete just denotes when all items have been returned.

Trivial fix (1 liner). Needs testcase for this case as well to verify it does not regress again in the future.