Custom Query (18300 matches)

I had created the button ("dijit/form/Button") as follows:

new Button({
	onClick: function() {
		console.log("I have been clicked");
	}
	, showLabel: true
	, label: "My button"
	, title: "Title goes here"
});

In IE11, right click on the button, it will open the browsers default popup menu. Press "Esc", or click somewhere else to close the popup menu => the button is clicked anyway. This doesn't happen only to buttons, but pretty much all widgets.

I think the problem is in touch.js at:

if(hasPointer){
	 // MSPointer (IE10+) already has support for over and out, so we just need to init click support
	domReady(function(){
		win.doc.addEventListener(pointer.down, function(evt){
			doClicks(evt, pointer.move, pointer.up);
		}, true);
	});
}else if(hasTouch){
	domReady(function(){
	...

I don't know enough about the inner workings of Dojo, but I think it might need to be as follows:

if(hasTouch){
	if(hasPointer){
		 // MSPointer (IE10+) already has support for over and out, so we just need to init click support
		domReady(function(){
			win.doc.addEventListener(pointer.down, function(evt){
				doClicks(evt, pointer.move, pointer.up);
			}, true);
		});
	} else {
		domReady(function(){
		...

Change the build code to copy files in javascript rather than spawning "cp" command. Tests show this is faster, see ​https://github.com/dojo/util/pull/28.

​https://github.com/dojo/dojox/pull/120