Custom Query (18300 matches)

When using dojo.lfx.html.propertyAnimation in Firefox, the following code is executed against properties with color values:

for(var j = 0 ; j < prop.startRgb.length ; j++){
    value += Math.round(((prop.endRgb[j] - prop.startRgb[j]) * n) + prop.startRgb[j]) + (j < prop.startRgb.length - 1 ? "," : "");
}

(src/lfx/html.js line 146)

The problem is at "+ prop.startRgb[j]"--in Firefox (v2.0.0.1), prop.startRgb[j] is treated as a string, not an integer, so the value is concatenated onto the result of "((prop.endRgb[j] - prop.startRgb[j]) * n)" instead of added to its value.

As a workaround, wrapping prop.startRgb[j] in parseInt() works, but I suspect the dojo.gfx.color.Color.toRgb() method should really be returning an array of integers and not strings in the first place.

src/lfx/html.js uses 'height' in dojo.lfx.html.wipeIn() as name for a variable which causes the compressor to produce the wrong code:

var height = dojo.html.getBorderBox(node).height;
...
with(node.style){
	overflow = oprop.overflow;
        height = oprop.height;
}

compresses to:

var _593=dojo.html.getBorderBox(node).height;
...
with(node.style){
overflow=_58f.overflow;
_593=_58f.height;
}

This causes lfx.wipeIn/wipeOut to grow the node on every invocation as the height is not adjusted correctly. TitlePane? widget is affected, probably others too...

proposed fix:

--- src/lfx/html.js.old Thu Mar  8 12:23:02 2007
+++ src/lfx/html.js     Thu Mar  8 12:33:24 2007
@@ -238,7 +238,7 @@
                        position = "absolute";
                        display = "";
                }
-               var height = dojo.html.getBorderBox(node).height;
+               var origHeight = dojo.html.getBorderBox(node).height;
                with (node.style) {
                        top = origTop;
                        left = origLeft;
@@ -246,7 +246,7 @@
                        display = "none";
                }
                var anim = dojo.lfx.propertyAnimation(node, {"height":{start:1, end:function () {
-                       return height;
+                       return origHeight;
                }}}, duration, easing);
                anim.connect("beforeBegin", function () {
                        oprop.overflow = node.style.overflow;

the function dojo.html.isDisplayed() always returns true : this code :

alert("isDisplayed " + inputElement.style.display + " " + dojo.html.isDisplayed(inputElement));

shows a text box with that : "isDisplayed none true"

whereas that function is supposed to test if style.display is not 'none' !!!

the concerned input element is that way :

<input type="text" name="/something/something/@size-x" style="display: none;"/>

is the function dojo.html.isVisible better ?

Thank you for all the work you did in dojo, that's really amazing.