Custom Query (18300 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (154 - 156 of 18300)

Ticket Resolution Summary Owner Reporter
#18772 fixed [patch][ccla] Add dojox/store/DynamoDB implementation dylan dylan
Description

https://github.com/dojo/dojox/pull/163

#18769 fixed request handleAs: 'json' try to parse non 2XX responses dylan anders
Description

If the server does not respond with JSON formated content for response codes >= 300, this is not desirable.

This could be solved by checking the status before trying to parse.

In dojo-release-1.10.4 dojo/request/xhr.js line 67 - 83

if(!error){
  try{
    handlers(response);
  }catch(e){
    error = e;
  }
}

if(error){
  this.reject(error);
}else if(util.checkStatus(_xhr.status)){
  this.resolve(response);
}else{
  error = new RequestError('Unable to load ' + response.url + ' status: ' + _xhr.status, response);

  this.reject(error);
}

Could be changed to:







if(error){
  this.reject(error);
}else if(util.checkStatus(_xhr.status)){
  try{
    handlers(response);
    this.resolve(response);
  }catch(e){
    error = e;
    this.reject(error);
  }
}else{
  error = new RequestError('Unable to load ' + response.url + ' status: ' + _xhr.status, response);

  this.reject(error);
}

#18768 fixed remove widgetsInTemplate property and instead detect automatically bill paulrutter
Description

As stated on https://dojotoolkit.org/documentation/tutorials/1.10/templated/, the _WidgetsInTemplateMixin should only be mixed in when needed, to prevent a performance penalty.

Although this is good advice, it often happens that the mixin is used by default (copied from another widget), even though no widgets are declared in the template. This is done to prevent a hard to debug situation where a widget is added in template, but the mixin "_WidgetsInTemplateMixin" is not present.

This case could be easily detected and if so, should prevent the costly "beforeFillContent" to be executed.

In my specific case, i fixed this by applying a monkey patch:

var oldFillContentMethod = _WidgetsInTemplateMixin.prototype._beforeFillContent;
_WidgetsInTemplateMixin.prototype._beforeFillContent = function() {
  /* start overrule */
  if (this.templateString && this.templateString.indexOf("data-dojo-type") > -1) {
    // just call the "core" method
    oldFillContentMethod.apply(this, arguments);
  }
  /* end overrule */
};

I think this should be added to the "_WidgetsInTemplateMixin", or do i miss something here?

Note: See TracQuery for help on using queries.