Custom Query (18300 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (136 - 138 of 18300)

Ticket Resolution Summary Owner Reporter
#9038 fixed dojox.image.lightbox is completely broken in 1.3 dante Aleksey Rechinskiy
Description

Hi.. I can't believe the dojo components is such badly tested before new release, but it is :(

dojox.image.lightbox can hang a page completely in some cases in FF3.0.8 or IE6 (have not tested in other browsers). See below:

behavior 1.

  • resize you browser to height, smaller than height of "tall" picture, referenced on the page. 1024x450 is enough.
  • click on 'large than viewport?' in "Individual" section to see blue rectangle. Close lightbox.
  • next click on 'tall' to hang the page. It will display only a small white rectangle instead of picture without any controls to close that "Lightbox". Also, you wouldn't be able to refresh the page with ctrl+r, it just wouldn't work.

Looks like, you will get the same behavior, if you first click on any other link, not only 'large than viewport?'.

If you play a bit more with the page after reloading, you can find a lot of other bugs.

For example:

behavior 2.

  • open the page in browser window maximized
  • click 'tall' to see the picture. Close lightbox.
  • resize browser window to same 1024x450
  • click 'tall' again to lock the page in other way. You will see only a underlay, but no lightbox. Have you noticed scrollbars? Try to scroll page down...

behavior 3.

  • open the page in browser window maximized
  • click 'tall' to see the picture. Don't close it
  • resize browser window to smaller size. Now you will not be able to close lightbox again.

I have found another bug with lightbox, but can't reproduce it on the test page. Under certain cases, after closing a lightbox, the page layout can be damaged. It looks like the page got very big or moved offscreen invisible element, that cause a scrollbars to appear. If one moves the scrollbars, no element becomes visible, only empty space. I think, that bug can be caused by the same issue, as bugs I described earlier, so I'll check if it appears after fix will be available.

Hope it will be fixed very soon.

Also, I would suggest to connect "onclick" on underlay to Lightbox::hide(). It would greatly improve usability of a Lightbox. In a light of single DialogUnderlay? instance in dijit._underlay, you'll have to make some simple isLightboxOpened() tracking code, and check it before actually calling hide() function. Underlay "onclick" should be connected to hide() function, not any other function, to protect any lightbox-derived classes.

#9039 wontfix var float; causes ShrinkSafe to fail in release mode. alex Aleksey Rechinskiy
Description

Create js file with variable var float; This variable is legal (it works as expected in FF3, IE6-7, Opera9.64 and makes me think, that it is legal)

Try to build the file in release mode. The complete build parameters are:

build.bat profileFile=%HOMEDIR%\myjs.profile.js action=clean,release releaseName=rel releaseDir="../../../c/" layerOptimize="shrinksafe" optimize="shrinksafe" copyTests=false cssOptimize=comments mini=true stripConsole=normal

When the build goes to optimizing baked file, you will get the following fatal error message:

release:  Optimizing (shrinksafe) file: ../../../c/rel/dojo/../App/baked-c.js
js: line 25688: missing variable name
js:     var float='dfd';
js: ..........^
#9060 fixed Dijit test.html fails bill Aleksey Rechinskiy
Description

.\dojo1.3\dijit\tests\test.html fails to start in ff3.0.8 and ie6 because of unhandled exception in dijit.form.Button line 101: this.params is undefined.

99 _fillContent: function(/*DomNode*/ source){
98 // Overrides _Templated._fillcContent().
99 // If button label is specified as srcNodeRef.innerHTML rather than
100 // this.params.label, handle it here.
101 if(source && !("label" in this.params)){
102 this.attr('label', source.innerHTML);
103 }
Note: See TracQuery for help on using queries.