Custom Query (18300 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (79 - 81 of 18300)

Ticket Resolution Summary Owner Reporter
#12218 fixed [patch][ccla] dojox.mobile.ScrollableView cannot be created dynamically Jared Jurkiewicz zhangyp
Description

Current buildRendering logic in scrollable view assume that the scrollable view is created and initialized according to html template.

When we create scrollable view by var view = new dojox.mobile.ScrollableView?({id:"view"}); Line 41 of ScrollableView?.js for(i = 0, idx = 0, len = this.srcNodeRef.childNodes.length; i < len; i++){ will report error because this.srcNodeRef is null

Digging into this issue, I found other problems when creating scrollable view dynamically. For example, at Line 61 of ScrollableView?.js for(i = 0, len = this.domNode.parentNode.childNodes.length; i < len; i++){ this.domNode.parentNode is undefined when creating dynamically. After creating the view, if we call addChild to add footer or header, it will be added to containerNode instead of the domNode which is the expected node according to buildRendering logic. (I guess there should be specific methods to add footer and header in scrollable view)

All these problems lead to one question, do we support to create scrollable view dynamically? If not, we need to document the reason (For example, fast initialization or etc. ) and notify the users about the expected way to use it.

#12485 fixed [patch][ccla]TabBar - CSS Size Definition on Icon is not Honored Chris Mitchell zhangyp
Description

This is a bug regarding the size of the icon in TabBar?. The CSS declaration of the height and width of the icon image is not honored. Thus, if the image original size exceeds the CSS size, sometimes the icon will show in its original size. Please see the attached picture. The root cause is the following statement which is supposed to fix a drawing issue in iPhone and Safari.

this.style.width = this.width + "px"; this.style.height = this.height + "px";

The problem is that if the size is specified through CSS, then it's "this.style.width" and "this.style.height". The above code won't work.

A possible way is to use the following statements.

var originDisplay = this.style.display; this.style.display = "none"; this.style.display = originDisplay;

Letting the icon hide and show seems to fix this problem.

#12519 worksforme replacement of AMD with dojo.require/dojo.declare in dojo build cause syntax error Rawld Gill zhangyp
Description

I am trying to build dojo.js layer which includes dojo.json. Here is the layer for dojo.js

{

name: "dojo.js", customBase: true, dependencies: [

"dojo._base.declare", "dojo._base.lang", "dojo._base.array", "dojo._base.window", "dojo._base.event", "dojo._base.connect", "dojo._base.html", "dojo._base.json"

]

}

However, it will cause the syntax error report of invalid return in dojo.json. Here is how dojo.json is defined using AMD. define("dojo/json", [], function(){

var hasJSON = typeof JSON != "undefined" var features = {

"json-parse": hasJSON, all the parsers work fine Firefox 3.5/Gecko 1.9 fails to use replacer in stringify properly https://bugzilla.mozilla.org/show_bug.cgi?id=509184

"json-stringify": hasJSON && JSON.stringify({a:0}, function(k,v){return v
1}) == '{"a":1}'

}; function has(feature){

return features[feature];

} if(has("json-stringify")){

return JSON;

}else{

......

}

The line of return JSON; tries to return JSON as dojo.json and it is correct because it is in the body of a function. When dojo utility build dojo.js layer, it tries to replace AMD with dojo.require and dojo.declare. Here is the code generated in dojo.js.uncompressed.js.

if(!dojo._hasResourcedojo.json?){ _hasResource checks added by build. Do not use _hasResource directly in your code. dojo._hasResourcedojo.json? = true; dojo.provide("dojo.json");

var hasJSON = typeof JSON != "undefined" var features = {

"json-parse": hasJSON, all the parsers work fine Firefox 3.5/Gecko 1.9 fails to use replacer in stringify properly https://bugzilla.mozilla.org/show_bug.cgi?id=509184

"json-stringify": hasJSON && JSON.stringify({a:0}, function(k,v){return v
1}) == '{"a":1}'

}; function has(feature){

return features[feature];

} if(has("json-stringify")){

return JSON;

} else{......}

The line of return JSON is invalid because it is not in the body of a function. I am not sure whether it is a bug of ShrinkSafe? but it is apparently a bug of dojo utility.

Note: See TracQuery for help on using queries.