Custom Query (18300 matches)


Show under each result:

Results (43 - 45 of 18300)

Ticket Resolution Summary Owner Reporter
#15834 fixed demos/touch: the slider is nearly unusable on mobile devices cjolif Adrian Vasiliu

Below a (rotatable) pie chart, demos/touch shows a dijit.form.HorizontalSlider? to allow to rotate the chart. Now, in Dojo 1.8, the slider works fine on desktop browsers, but is nearly unusable on mobile devices (touch-enabled browsers). This works much better in Dojo 1.7.3, so it seems a regression in Dojo 1.8.

How to reproduce:

  1. Launch demos/touch/demo.html on any mobile device (tested on iPhone 4S iOS 5.0.1 and Samsung Galaxy Tab Android 2.2).
  2. Touch the slider's knob to change the value.

=> In Dojo 1.8, this works 2 or 3 times, then stops working (the knob doesn't move) despite many attempts to touch the knob precisely. After many attempts, it works for a few times again, then stop working again and so on.

For dijit's slider, some ergonomy issues when running on mobile devices are limitations that can be also be seen with dijit/tests/test_Slider.html for instance. In particular, the sensitivity area around the slider is a bit small, the user needs to touch it quite precisely. However, in test_Slider.html it is still usable, while in demos/touch it is nearly unusable.

This trouble is specific to demos/touch and appears to be due to a z-ordering issue: the piechart being a css-rotated div, it can overlap (in an invisible manner) the slider thus trapping the events. The z-order was already used for dealing with this issue, but it was used on the parent div of the slider, instead of the slider itself, and the z-index is NOT inherited from parent by default.

On the longer run, I think it would rather make sense for demos/touch to use dojox/mobile/Slider instead - given that the mobile devices are the main target of touch-enabled apps, using the specialized widgets for this platform sounds logic.

Anyway, for now I attach a fix proposal for the current demo (tested okay on the two mobile devices mentioned above).

Side note, in demos/touch it is also not possible to move the knob (change the value) by touching/clicking somewhere along the slider but outside the knob. The attached patch also includes the activation of this feature (clickSelect at true on the slider widget).

#15892 fixed [cla][patch] dojox/gesture: "Uncaught TypeError: Illegal invocation" on Android devices Evan Adrian Vasiliu

Loading on Android devices the following test: dojox/gesture/tests/test_gesture.html the console shows many times: Uncaught TypeError?: Illegal invocation <path>/dojox/gesture/Base.js:267

The error is raised by a call to e.preventDefault()" in Base._process.

Exactly the same error hurts in demos/touch/demo.html (which uses dojox/gesture) as soon as you try to rotate the pie chart using the multi-touch gesture. Apparently as a consequence of this error, it is not possible to rotate the chart by the gesture on any Android device which is supposed to support it, such as Samsung Galaxy SIII Android 4.0.4, HTC One X Android 4.0.3.

The same exception is also raised on Android 2.2 devices, such as HTC Desire Android 2.2 even tough mutli-touch is not supported.

#15947 fixed dojox/mobile/tests/test_Button: styling of custom button is broken in Firefox Eric Durocher Adrian Vasiliu

dojox/mobile/tests/test_Button includes a dojox/mobile/Button with custom CSS. This button shows, as expected, with red filling in webkit browsers, but it shows gray in Firefox 15.

This is due to the custom CSS used in the test itself. The attached patch fixes the test.

Note: See TracQuery for help on using queries.