Ticket #8102 (closed defect: fixed)

Opened 8 weeks ago

Last modified 7 weeks ago

dojo.query broken in Safari3.2

Reported by: virsir Owned by: alex
Priority: high Milestone: 1.2.3
Component: Core Version: 1.2.1
Severity: critical Keywords:
Cc: phiggins, peller, jburke, alex

Description

It looks like it can not handle upperclass className properly. I am not sure whether there is other issues in safari 3.2 when querying dom nodes.

try below simple html in Safari3.2: 

    <script type="text/javascript" src="dojo/dojo.js">
    </script>
    <body>
    	<div class="hahaA"></div>
    </body>
    <script type="text/javascript">
      dojo.addOnLoad(function(){
      	 var a = dojo.query(".hahaA")[0];
     	 alert(a)
      })
    </script>

Change History

Changed 8 weeks ago by peller

  • owner changed from anonymous to alex

Changed 7 weeks ago by dante

Just to update on this, it seems the parser is affected by this too?

From dijit/layout/tests/test_AccordionPane.html: 

dojo.query("[dojotype]").length;
15
dojo.query("[dojoType]").length;
0

Though my testing comes from discovering the parser not working at all in Safari4 "dev" release. The _prog version of the above test works as expected.

Tested Safari4/dev, so not necessarily a bug yet, but seems identical to this ticket (mixed case query selections?)

Changed 7 weeks ago by dylan

Seems suspiciously related to our fix for Safari 3.1: http://bugs.dojotoolkit.org/ticket/6252

Changed 7 weeks ago by dante

A little more info, Safari 3.2 was just pushed to my machine (thanks, Apple) -- Several dojo.query unit tests failing in trunk:

mostly saying: SYNTAX_ERR: DOM Exception 12

eg: 

dojo.is(1, dojo.query("#foo ~").length);

Also, NodeList.concat, place, splice, and orphan tests failing. Not sure if that should be a new ticket, or it is all related to some underlying thing.

Changed 7 weeks ago by alex

  • cc phiggins, peller, jburke, alex added
  • status changed from new to closed
  • resolution set to fixed

fixed in [15749] and [15750], back-ported to the 1.1 and 1.2 branches for release in 1.2.3 and 1.1.2

Changed 7 weeks ago by bill

  • milestone changed from 1.3 to 1.2.3
Note: See TracTickets for help on using tickets.