Ticket #8100 (new defect)

Opened 8 weeks ago

Last modified 5 weeks ago

[CLA-patch] ComboBox in a Dialog : e.preventDefault() issue with Firefox

Reported by: jbondc Owned by: bill
Priority: normal Milestone: 1.3
Component: DnD Version: 1.2.1
Severity: normal Keywords:
Cc:

Description

Context: While trying to show ComboBox? inside a Dialog, when moving the Dialog overlay, the popup box does not close in Firefox.

Solution: Do not call e.preventDefault() in dojo.dnd.Moveable (FF only)

Attached is a patch for dojo and dijit. Also a viewport calculation fix for Opera (Dialog)

Attachments

dojo.patch (0.6 kB) - added by jbondc 8 weeks ago.
dijit.patch (3.8 kB) - added by jbondc 8 weeks ago.

Change History

Changed 8 weeks ago by jbondc

Changed 8 weeks ago by jbondc

Changed 7 weeks ago by bill

  • owner set to elazutkin
  • component changed from Dijit to DnD

I fixed getViewport() in [15845]. As for the main point of this ticket, handing to Eugene since it's really a DnD issue.

Changed 6 weeks ago by elazutkin

  • status changed from new to assigned
  • milestone changed from tbd to 1.2.3

Changed 5 weeks ago by peller

Eugene, is this critical and well-tested for 1.2.3? If so, it needs to go in now.

Changed 5 weeks ago by elazutkin

  • owner changed from elazutkin to bill
  • status changed from assigned to new

The attached fix for Moveable is no good --- text starts to get selected randomly when the fix is in place. Try http://archive.dojotoolkit.org/nightly/dojotoolkit/dojo/tests/dnd/test_moveable.html before doing anything drastic.

Reassigning to Bill for his consideration.

Changed 5 weeks ago by peller

  • milestone changed from 1.2.3 to 1.3
Note: See TracTickets for help on using tickets.