Changeset 15416

Timestamp:

10/07/08 06:35:00 (3 months ago)

Author:

toonetown

Message:

Refs #7788 addresses this performance issue in trunk - would like to have someone look over it before committing it to 1.2 branch.

Location:

dijit/trunk

Files:

• form/Form.js (modified) (5 diffs)
• tests/form/test_validStatePerformance.html (added)

dijit/trunk/form/Form.js

@@ -301 +301 @@
                 isValid: function(){
                         // summary: make sure that every widget that has a validator function returns true
+                        this._invalidWidgets = [];
                         return dojo.every(this.getDescendants(), function(widget){
-                                return widget.disabled || !widget.isValid || widget.isValid();
-                        });
+                                var isValid = widget.disabled || !widget.isValid || widget.isValid();
+                                if(!isValid){
+                                        this._invalidWidgets.push(widget);
+                                }
+                                return isValid;
+                        }, this);
                 },
                 
@@ -313 +318 @@
                 },
                 
-                _widgetChange: function(){
+                _widgetChange: function(widget){
                         // summary: connected to a widgets onChange function - update our 
                         //                      valid state, if needed.
-                        var isValid = this.isValid();
+                        var isValid = this._lastValidState;
+                        if(widget && !widget.disabled && widget.isValid){
+                                this._invalidWidgets = dojo.filter(this._invalidWidgets||[], function(w){
+                                        return (w != widget);
+                                }, this);
+                                if(!widget.isValid()){
+                                        this._invalidWidgets.push(widget);
+                                }
+                                isValid = (this._invalidWidgets.length === 0);
+                        }
                         if (isValid !== this._lastValidState){
                                 this._lastValidState = isValid;
@@ -340 +354 @@
                                 ),
                                 function(widget){
-                                        return _this.connect(widget, "validate", "_widgetChange");
+                                        return _this.connect(widget, "validate", dojo.hitch(_this, "_widgetChange", widget));
                                 }
                         );
@@ -346 +360 @@
                         // Call the widget change function to update the valid state, in 
                         // case something is different now.
-                        this._widgetChange();
+                        this._widgetChange(null);
                 },
                 
@@ -355 +369 @@
                         //  yet.
                         this._changeConnections = [];
+                        this._lastValidState = this.isValid();
                         this.connectChildren();
-                        this._lastValidState = this.isValid();
                 }
         });